Change how we specify Python versions for testing #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
added a commit
that referenced
this pull request
Apr 19, 2024
Fixes #1207. We use `list[str]` in type hints rather than `List[str]`, which was only added in Python 3.9. So it broke CI. Python 3.9 is fine as a floor, given that Python 3.12 is newest.
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
We currently test everything with Python 3.11, but this is a problem as not all writers have it available on their system. We also want to make sure our docs work with as many versions of Python as possible. This PR allows writers to test their docs with any version of Python, and sets CI to test with Python 3.8 (the minimum version that Qiskit supports).
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Fixes Qiskit#1207. We use `list[str]` in type hints rather than `List[str]`, which was only added in Python 3.9. So it broke CI. Python 3.9 is fine as a floor, given that Python 3.12 is newest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently test everything with Python 3.11, but this is a problem as not all writers have it available on their system. We also want to make sure our docs work with as many versions of Python as possible.
This PR allows writers to test their docs with any version of Python, and sets CI to test with Python 3.8 (the minimum version that Qiskit supports).